Revert @trusted hotfix for std.uni #6638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlang-bot
added
the
Review:WIP
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#6638" |
wilzbach
changed the title
wilzbach
commented
Jul 19, 2018
| // TODO: change this to data[] once the -dip1000 errors have been fixed | ||
| // see e.g. https://github.com/dlang/phobos/pull/6638 | ||
| import std.array : array; | ||
| return Intervals!(typeof(data.array))(data.array); |
Contributor
Author
There was a problem hiding this comment.
Looks like this part of -dip1000 is still under work, so I presume it's best to do the ugly allocation for now, s.t. Walter can continue to work on DIP1000 and this stays @safe.
wilzbach
added
Review:Blocking Other Work
and removed
Review:WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6626
As many modules depend on
std.uni, we would have needed to revert almost all of the existing-dip1000work.The
@trustedshouldn't be necessary here, but so far no one has come up with a good fix for std.uni :/