Skip to content

Don't emit debug messages in non-debug unittest build #6827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlang-bot merged 2 commits into from
Jan 5, 2019
Merged

Don't emit debug messages in non-debug unittest build #6827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89b6056
std/experimental/typecons.d: Hide pragma(msg) in debug code
ibuclaw Jan 1, 2019
a5751e5
std/math.d: Don't emit message saying that test is disabled
ibuclaw Jan 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions std/experimental/typecons.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,12 @@ if (Targets.length >= 1 && allSatisfy!(isMutable, Targets))
else
{
enum foundFunc = findCovariantFunction!(TargetMembers[i], Source, SourceMembers);
static if (foundFunc == -1)
pragma(msg, "Could not locate matching function for: " ~ TargetMembers[i].stringof);
debug
{
static if (foundFunc == -1)
pragma(msg, "Could not locate matching function for: ",
TargetMembers[i].stringof);
}
enum hasRequiredMethods =
foundFunc != -1 &&
hasRequiredMethods!(i + 1);
Expand Down
16 changes: 7 additions & 9 deletions std/math.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7495,15 +7495,13 @@ if (isFloatingPoint!(F) && isIntegral!(G))

assert(pow(x, neg1) == 1 / x);

version (X86_64)
{
pragma(msg, "test disabled on x86_64, see bug 5628");
}
else version (ARM)
{
pragma(msg, "test disabled on ARM, see bug 5628");
}
else
// Test disabled on most targets.
// See https://issues.dlang.org/show_bug.cgi?id=5628
version (X86_64) enum BUG5628 = false;
else version (ARM) enum BUG5628 = false;
else enum BUG5628 = true;

static if (BUG5628)
{
assert(pow(xd, neg2) == 1 / (x * x));
assert(pow(xf, neg8) == 1 / ((x * x) * (x * x) * (x * x) * (x * x)));
Expand Down