ieeeFlags unittest: the optimizer might remove operations that the te…#7126
Merged
thewilsonator merged 1 commit intodlang:masterfrom Aug 17, 2019
Merged
ieeeFlags unittest: the optimizer might remove operations that the te…#7126thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7126" |
thewilsonator
approved these changes
Aug 9, 2019
Member
Author
|
Just noticed that there are two more unittests that almost do the same. Amended similar fixes, but they could also just be deleted (they don't look like useful examples with these workarounds). |
…st is depending upon
Member
Author
|
Ping! Any reason for holdup? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…st is depending upon
The optimizer removes all traces of
abecause it is const-folded tonan. That means no side effects appear.This test is failing here: https://dev.azure.com/dlanguage/dmd/_build/results?buildId=3982&view=logs&jobId=995050be-48e9-58a0-3553-d9a547fe6c20&taskId=3bcde2a0-396a-5c5e-c7d5-d0568bb0ee4b&lineStart=4275&lineEnd=4276&colStart=1&colEnd=1
Not sure why it doesn't appear on other platforms, but it triggers when using dmd built against the MS C runtime.