Skip to content

Don't rely on implicit conversion of int to fp for args to intrinsic …#7461

Merged
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:thewilsonator-patch-6
Apr 27, 2020
Merged

Don't rely on implicit conversion of int to fp for args to intrinsic …#7461
dlang-bot merged 1 commit intodlang:masterfrom
thewilsonator:thewilsonator-patch-6

Conversation

@thewilsonator
Copy link
Contributor

…math functions

@thewilsonator thewilsonator added the Review:Trivial typos, formatting, comments label Apr 27, 2020
@thewilsonator thewilsonator requested a review from ibuclaw as a code owner April 27, 2020 03:49
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#7461"

@thewilsonator thewilsonator force-pushed the thewilsonator-patch-6 branch from e14b573 to db9b297 Compare April 27, 2020 05:49
@dlang-bot dlang-bot merged commit 30452a3 into dlang:master Apr 27, 2020
@thewilsonator thewilsonator deleted the thewilsonator-patch-6 branch May 11, 2022 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge:auto-merge Review:Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants