Rewrite std.meta.Stride using AliasAssign#7758
Closed
WalterBright wants to merge 1 commit intodlang:masterfrom
Closed
Rewrite std.meta.Stride using AliasAssign#7758WalterBright wants to merge 1 commit intodlang:masterfrom
WalterBright wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7758" |
WalterBright
force-pushed
the
AliasAssignStride
branch
from
33a1ca7 to
ac6f9a1
Compare
WalterBright
force-pushed
the
AliasAssignStride
branch
from
ac6f9a1 to
a9de9d0
Compare
Member
Author
Member
Master was green 4 hours ago, so I doubt so: https://github.com/dlang/phobos/commits/master |
Contributor
|
I saw similar failures recently in #7702. They went away after a rebase. |
Collaborator
|
@WalterBright Please rebase. |
Collaborator
|
ping @WalterBright . Where are we with this? |
Collaborator
|
Closing in favor of #8047 as it produces the same change but in less lines of code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also added shortcut when stepSize is 1.