Skip to content

Improve Reverse#8037

Merged
dlang-bot merged 1 commit intodlang:masterfrom
andralex:Reverse
Aug 27, 2021
Merged

Improve Reverse#8037
dlang-bot merged 1 commit intodlang:masterfrom
andralex:Reverse

Conversation

@andralex
Copy link
Member

@andralex andralex commented May 3, 2021

This has no visible effect on build times but reduces max memory occupied.

@andralex andralex requested a review from MetaLang as a code owner May 3, 2021 21:24
@dlang-bot
Copy link
Contributor

dlang-bot commented May 3, 2021

Thanks for your pull request, @andralex!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8037"

}
alias Reverse = AliasSeq!();
static foreach_reverse (arg; args)
Reverse = AliasSeq!(Reverse, arg);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know about this feature.

dreg says this works as of 2.095.0, but I see nothing about this in https://dlang.org/changelog/2.095.0.html.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dlang/dmd#11846

Somehow the changelog never made it to dlang.org, I wonder why.

@adamdruppe
Copy link
Contributor

Nice foreach_reverse!

@andralex
Copy link
Member Author

andralex commented May 5, 2021

Nice foreach_reverse!

Yep, let the compiler do the heavy lifting!

@RazvanN7 RazvanN7 closed this Aug 27, 2021
@RazvanN7 RazvanN7 reopened this Aug 27, 2021
@RazvanN7
Copy link
Collaborator

(rebased and restarted CIs)

@dlang-bot dlang-bot merged commit 6544a81 into dlang:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments