Replace quadratic Reverse with quasilinear#8301
Closed
andralex wants to merge 1 commit intodlang:masterfrom
Closed
Replace quadratic Reverse with quasilinear#8301andralex wants to merge 1 commit intodlang:masterfrom
andralex wants to merge 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @andralex! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8301" |
Member
Author
|
Wait, Reverse uses |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since alias sequences are stored internally as arrays,
Reverseis quadratic because it builds an array by prepending an element. Each step creates a new array and copies the existing one into it.The proposed implementation uses the quadratic algorithm for short arrays (where it is still efficient) and switches to a divide & conquer approach for larger arrays. Unless I'm wrong it does
O(n)work for each level of the tree formed by halving, for a total ofO(n long n)work. The short arrays case improves this by a constant. factor.I think we ought to examine other compile-time algorithms with an eye for compile-time complexity. Also, per the #8039, this pattern should be detected and implemented so it has constant amortized complexity:
x = AliasSeq!(x, one_more_element);