Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around issue 22619 - Avoid Nullable copy ctor unless required #8358

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

kinke
Copy link
Contributor

@kinke kinke commented Jan 10, 2022

Copy ctors are still buggy, so unconditionally adding one for Nullable is everything but a non-breaking change (and was added in the 2.098.1 point release - #8318).

Copy ctors are still buggy, so unconditionally adding one for Nullable
is everything but a non-breaking change (and was added in the 2.098.1
point release).
@kinke kinke requested a review from MetaLang as a code owner January 10, 2022 15:50
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22619 regression [REG2.098.1] Nullable regression introduced by new copy ctor

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8358"

@burner
Copy link
Member

burner commented Jan 10, 2022

does this also make it work with the nullable function?

@kinke
Copy link
Contributor Author

kinke commented Jan 10, 2022

does this also make it work with the nullable function?

Depends on T. Symmetry's REPL finally compiles with this.

@burner
Copy link
Member

burner commented Jan 10, 2022

@RazvanN7 this seems to be fixing my problem as well.

thank you @kinke

@RazvanN7 RazvanN7 merged commit ba7529c into dlang:stable Jan 11, 2022
@kinke kinke deleted the fix22619 branch January 11, 2022 09:17
@burner
Copy link
Member

burner commented Jan 11, 2022

I'm happy that this is fixed, but

this(ref return scope inout Nullable!T rhs) inout

having all these keywords on a ctor is just mad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants