-
-
Notifications
You must be signed in to change notification settings - Fork 747
Fix macros inside backticks #8739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes Issue 23849 - Ddoc $(LPAREN) and $(RPAREN) not formatted properly Introduced by dlang#6391 in 2018.
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8739" |
|
Some of these changes are wrong with the current ddoc - I thought macros weren't expanded inside backticks, and they aren't for the filed issue. It seems in some cases they are expanded. The spec doesn't seem clear on the behaviour:
|
Is it intended for macro expansion to always happen inside backticks? |
|
Ah I see what the problem is, ddoc actually always expands macros but ddox doesn't for the issue code. |
|
Filed dlang/ddox#241. |
This is the behaviour of ddoc and ddox. (See dlang/phobos#8739 (comment)).
This is the behaviour of ddoc and ddox. (See dlang/phobos#8739 (comment)).
This is the behaviour of ddoc and ddox. (See dlang/phobos#8739 (comment)).
Fixes Issue 23849 - Ddoc
$(LPAREN)and$(RPAREN)not formatted properlyIntroduced by #6391 in 2018.