Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment of buffers in kernighan_ritchie unittests. #8965

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

JohanEngelen
Copy link
Contributor

This fixes a bug with strong optimization (LDC LTO). ubyte arrays are not necessarily word aligned.

@dlang-bot
Copy link
Contributor

dlang-bot commented Apr 1, 2024

Thanks for your pull request and interest in making D better, @JohanEngelen! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + phobos#8965"

@JohanEngelen
Copy link
Contributor Author

JohanEngelen commented Apr 1, 2024

I don't understand the circle-CI failure:

parsing std/experimental/allocator/building_blocks/kernighan_ritchie.d
generated/linux/debug/64/publictests/std_experimental_allocator_building_blocks_kernighan_ritchie.d(650): Error: no property `Node` for type `std.experimental.allocator.building_blocks.kernighan_ritchie.KRRegion!(NullAllocator)`
std/experimental/allocator/building_blocks/kernighan_ritchie.d(99):        struct `KRRegion` defined here
make: *** [Makefile:679: std/experimental/allocator/building_blocks/kernighan_ritchie.publictests] Error 1

perhaps something buggy with generating the std_experimental_allocator_building_blocks_kernighan_ritchie.d file?

@kinke
Copy link
Contributor

kinke commented Apr 1, 2024

Please target stable.

Edit: Btw, this was already a problem 7 years ago in #5345. ;)

@dlang-bot dlang-bot merged commit 9f735fd into dlang:stable Apr 1, 2024
10 checks passed
@JohanEngelen JohanEngelen deleted the fixalign branch April 1, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants