Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 24550 - - formattedWrite should support string interpolation #9041

Closed
wants to merge 11 commits into from

Conversation

RubyTheRoobster
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

dlang-bot commented Aug 3, 2024

Thanks for your pull request and interest in making D better, @RubyTheRoobster! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
24550 enhancement formattedWrite should support string interpolation

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#9041"

@thewilsonator
Copy link
Contributor

please retitle the commit message "Fix Bugzliia Issue 24550 - - formattedWrite should support string interpolation"

@RubyTheRoobster
Copy link
Contributor Author

BuildKite seems to be failing because it doesn't properly recognize string interpolation syntax.

@pbackus
Copy link
Contributor

pbackus commented Feb 23, 2025

My understanding is that the "formatted" part of formattedWrite refers to the format string. If it's using interpolation, it's not really a "formatted" write, is it?

@LightBender
Copy link
Contributor

@RubyTheRoobster I agree with @pbackus that these methods are for format-strings and not IES strings. As such, I am going to close this PR, but if you think this is an error, please feel free to reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants