Fixes for -preview=rvaluerefparam
#9092
Open
+19
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dlang/dmd#17068 (comment)
hasToString
is a bit of a tangle, it tries to force passingFormatSpec
byconst ref
forcustomPutWriter
, but not forconstCharSinkFormatSpec
. It's not necessary to require it, I guess copying it is discouraged because it is slower than needed, but it's hard to statically enforce this in the presence of overloads.