Remove unneccsary array allocation#192
Merged
andralex merged 2 commits intodlang:masterfrom Aug 26, 2016
Merged
Conversation
Contributor
|
@wilzbach, thanks for your PR! By analyzing the annotation information on this pull request, we identified @andralex, @CyberShadow and @leandro-lucarella-sociomantic to be potential reviewers. @andralex: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
rdmd.d
Outdated
| bool anyNewerThan(T)(T files, SysTime t) | ||
| { | ||
| // Experimental: running newerThan in separate threads, one per file | ||
| if (false) |
Contributor
Author
There was a problem hiding this comment.
Btw it seems that this experiment is "over" and parallel compilation is now enabled by default. Should we remove the old cold?
Contributor
Author
|
As this is just a code cleanup - should we wait with this until I/we have enabled the |
Member
|
eh, we should be fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This immediately jumped into by eye during the discussion and review at #191. We only iterate once through the collection.