Add Phobos public tests extractor script by wilzbach · Pull Request #203 · dlang/tools

wilzbach · 2016-12-10T08:22:54Z

Adds a simple extraction utility that dumps all public unittests from Phobos in separate files, s.t. we can run them with rdmd and verify that all snippets on dlang.org are runnable (e.g. don't miss imports).

andralex

Alignment pliz

andralex · 2016-12-10T14:19:29Z

phobos_tests_extractor.d

+import std.range;
+import std.exception;
+import std.algorithm;
+import std.path;


On thing I'd like to add to our usual style guidelines is imports should be ordered alphabetically (it did happen at least to me to import something twice when the imports list is long). Also, I wonder how our opinionated community would feel about preferring comma-separated imports instead of one per line.

On thing I'd like to add to our usual style guidelines is imports should be ordered alphabetically

Good idea -> dlang-community/D-Scanner#382

Also, I wonder how our opinionated community would feel about preferring comma-separated imports instead of one per line.

I personally prefer line-separated imports because it's easy to add/remove them and the git log is clean.
For such scripts one wants to do sth. like import std.* - I have seen quite many people having their convenience scripting package that public imports most of Phobos

andralex · 2016-12-10T14:19:56Z

phobos_tests_extractor.d

+
+    alias visit = ASTVisitor.visit;
+
+	override void visit(const Unittest u)


alignment is off

andralex · 2016-12-10T14:20:21Z

phobos_tests_extractor.d

+	    // scan the previous line for ddoc header
+	    auto loc = u.location + 0;
+	    while (sourceCode[loc] != '\n')
+            loc--;


fix alingment (here, there, and everywhere)

andralex · 2016-12-10T14:20:45Z

phobos_tests_extractor.d

+
+        // write the origin source code line
+        outFile.write("// Line ");
+        outFile.write(sourceCode[0..loc].count("\n") + 2);


space around operators

andralex · 2016-12-10T14:21:21Z

phobos_tests_extractor.d

+        "inputdir|i", &inputDir,
+        "outputdir|o", &outputDir,
+        "ignore", &ignoredFilesStr,
+    );


add help strings?

wilzbach · 2016-12-10T19:37:05Z

Alignment pliz

Sorry - parts of this file were a bit older -> dfmted :)

andralex · 2016-12-14T17:07:49Z

phobos_tests_extractor.d

+
+    // file name without its parent directory, e.g. std/uni.d
+    string fileNameNormalized = (inputDir != ".") ? fileName.replace(inputDir,
+            "")[1 .. $] : fileName[1 .. $];


The line break is surprising. Also I'd factor it like this:

string fileNameNormalized = (inputDir == "." ? fileName : fileName.replace(inputDir, ""))[1 .. $];

wilzbach · 2016-12-15T04:46:26Z

chmodzip.d

            writefln("\texpandedSize = %s", de.expandedSize);
            writefln("\tcompressedSize = %s", de.compressedSize);
-            writefln("\teattr = %03o, %03o", de.externalAttributes >> 16, de.externalAttributes & 0xFFFF);
+            writefln("\teattr = %03o, %03o", de.fileAttributes);


The public fileAttributes does this in the setter

wilzbach · 2016-12-15T04:46:58Z

travis.sh

+        dmd -m$MODEL $file
+    done
+    # TODO: fix DustMite
+    #(cd DustMite && dmd -m$MODEL dustmite.d)


CyberShadow/DustMite#49

dmd -m$MODEL dustmite.d splitter.d

There is a Makefile rule for Dustmite already, why duplicate the build commands here?

wilzbach · 2016-12-15T04:47:09Z

travis.sh


-install_digger() {
-    $DIGGER build --model=$MODEL "master"
+run_digger() {


Digger gets installed with build_digger, here we really run it

- add module prefix flag - allow single files as input as well - beautify the ddoc comment header parsing - add check for empty files - more resistant leading dot/slashes removal

andralex · 2016-12-15T19:28:44Z

Will merge now. cc @CyberShadow @MartinNowak @WalterBright

wilzbach · 2016-12-16T00:43:34Z

Will merge now. cc @CyberShadow @MartinNowak @WalterBright

Thanks - I wanted to get the CI working before, but well luckily it does work at Phobos :)
dlang/phobos#4943

This was referenced Dec 10, 2016

Add check for public unittests dlang/phobos#4943

Merged

Edit & run examples from unittests dlang/dlang.org#1297

Merged

andralex requested changes Dec 10, 2016

View reviewed changes

wilzbach force-pushed the add-check-for-public-unittests branch from b9c0147 to 8ff7fe9 Compare December 10, 2016 19:35

andralex approved these changes Dec 14, 2016

View reviewed changes

wilzbach commented Dec 15, 2016

View reviewed changes

wilzbach mentioned this pull request Dec 15, 2016

Improve Travis CI setup -> compile all executable #205

Closed

wilzbach added 3 commits December 15, 2016 18:51

Add Phobos public tests extractor script

75e7358

Order imports

01fcda5

beautify the script and add module prefix flag

d9762d7

- add module prefix flag - allow single files as input as well - beautify the ddoc comment header parsing - add check for empty files - more resistant leading dot/slashes removal

wilzbach force-pushed the add-check-for-public-unittests branch from 36d0c0d to d9762d7 Compare December 15, 2016 17:51

andralex merged commit 184f5e6 into dlang:master Dec 15, 2016

wilzbach deleted the add-check-for-public-unittests branch December 15, 2016 22:19


		alias visit = ASTVisitor.visit;

		override void visit(const Unittest u)

Uh oh!

Conversation

wilzbach commented Dec 10, 2016

Uh oh!

andralex left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach Dec 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach commented Dec 10, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andralex commented Dec 15, 2016

Uh oh!

wilzbach commented Dec 16, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

wilzbach Dec 10, 2016 •

edited

Loading