Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lxml v5 breaks the lib #32

Open
femesq opened this issue Jan 31, 2024 · 6 comments · Fixed by femesq/inlinestyler#1 · May be fixed by #33
Open

lxml v5 breaks the lib #32

femesq opened this issue Jan 31, 2024 · 6 comments · Fixed by femesq/inlinestyler#1 · May be fixed by #33

Comments

@femesq
Copy link
Collaborator

femesq commented Jan 31, 2024

When updating lxml > 5 I've got AttributeError exception:

 'CSSSelector' object has no attribute 'evaluate'
 matching = CSSRelSelector.evaluate(document)

in this line: https://github.com/dlanger/inlinestyler/blob/master/inlinestyler/converter.py#L30
femesq added a commit to femesq/inlinestyler that referenced this issue Jan 31, 2024
@femesq
Update cssselect.py
29fc1c2 
Fix dlanger#32

Related to this Deprecation:
https://github.com/lxml/lxml/blob/3c902168c46c2e55b69f38b1b56d57c5296958f6/CHANGES.txt#L131

Follows this instruction: https://github.com/lxml/lxml/blob/lxml-4.9/src/lxml/xpath.pxi#L150
@femesq femesq mentioned this issue Jan 31, 2024
Merged
femesq added a commit to femesq/inlinestyler that referenced this issue Jan 31, 2024
@femesq
Merge pull request #1 from femesq/femesq-patch-1
488c598 
Update cssselect.py to fix dlanger#32
@femesq femesq linked a pull request Jan 31, 2024 that will close this issue
Open
@femesq femesq reopened this Feb 1, 2024
@femesq
Copy link
Collaborator Author

femesq commented Feb 1, 2024

Reopening until merged...

@selva-thiruarul
Copy link

facing the same issue, any update on this ?

@femesq
Copy link
Collaborator Author

femesq commented Apr 9, 2024

@selva-thiruarul
Check this: femesq@488c598

Don't know if the official lib is being maintained, so I can't say this fix will be merged.

@selva-thiruarul
Copy link

Thanks @femesq. I switched to css-inline. It works

@dlanger
Copy link
Owner

dlanger commented Apr 11, 2024

That's probably the right call - as the README says, this is pretty much unmaintained.

@marksteward marksteward mentioned this issue Apr 19, 2024
Closed
@rcarmo
Copy link

rcarmo commented May 3, 2024

Came here to report this, sad to see it unmaintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rcarmo @dlanger @femesq @selva-thiruarul