Skip to content

Conversation

@Gounlaf
Copy link
Contributor

@Gounlaf Gounlaf commented Feb 29, 2024

From #1568

  • Remove redundant checks
  • Add missing tests

Regards.

@Gounlaf Gounlaf changed the title tests: add missing tests for MagickImage.AdaptiveResize feat: remove redundant tests before creating MagickGeometry Feb 29, 2024
@Gounlaf Gounlaf changed the title feat: remove redundant tests before creating MagickGeometry opti: remove redundant tests before creating MagickGeometry Feb 29, 2024
@Gounlaf Gounlaf marked this pull request as ready for review February 29, 2024 22:19
@Gounlaf
Copy link
Contributor Author

Gounlaf commented Feb 29, 2024

It should be OK for review.

Copy link
Owner

@dlemstra dlemstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests. They need some minor patches but I will do this myself.

@dlemstra dlemstra merged commit 7aaa73f into dlemstra:main Mar 1, 2024
@Gounlaf Gounlaf deleted the remove-redundant-checks-magickgeometry branch March 1, 2024 10:35
This was referenced Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants