-
-
Notifications
You must be signed in to change notification settings - Fork 437
Use CallerArgumentExpressionAttribute in throw helpers #1788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CallerArgumentExpressionAttribute in throw helpers #1788
Conversation
# Conflicts: # src/Magick.NET/Statistics/PerceptualHash.cs
|
Thanks for your pull request it will probably take a while before I have time to look at this. Only quick thing that I saw was |
|
Removed the default value for
The third option causes ambiguity for |
|
It looks like you did not address that issue yet? Doing |
|
You are right. Updated to handle null message cases. |
dlemstra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this change, looks a lot better. I left a couple comments.
|
All comments have been resolved. Ready for review @dlemstra |
|
Will take a look at it this weekend. Thanks for all the fixes. |
The following changes have been made in throw helpers:
CallerArgumentExpressionAttributeto simplify throw assertions (nameof(parameterName)can be omitted in most cases)StringSyntaxAttributefor error message templates