Forward success response to fetch_raw_info callback (#47) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danschmidt5189
force-pushed
the
47-squashing-multivalued-fields
branch
2 times, most recently
from
93f2eb8
to
2a72d4c
Compare
|
Thanks for this. I have no objection to merge, I'll wait to hear from other collaborators. Thanks! |
vjt
approved these changes
Jul 18, 2018
Forwards the XML response received from CASAuth to the fetch_raw_info callback, which now accepts five arguments (cas, options, ticket, user info, and the raw response). Developers who override fetch_raw_info with a Proc are unaffected -- the new argument is silently discarded -- but developers who use a Lambda will need to update their code.
danschmidt5189
force-pushed
the
47-squashing-multivalued-fields
branch
from
2a72d4c
to
5fcb389
Compare
|
@vjt We tried this out on a few internal apps and were reminded that it's a breaking change for developers using That might also be worth noting in the Changelog, but I'll leave that to you and the other maintainers. Thank you! |
danschmidt5189
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
ServiceTicketValidator.success_bodyand passes it as a fifth argument to the user-suppliedfetch_raw_infocallback. This gives new clients access to the raw CAS XML response, allowing them to solve issues like #47 without breaking parsing for existing clients.There were previously no tests for the
fetch_raw_infocallback. That is now implicitly tested by checks on newcas:rolesfixture elements, which are populated by that callback.