Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping support for unmaintained Node versions #648

Closed
demurgos opened this issue Dec 28, 2017 · 2 comments
Closed

Consider dropping support for unmaintained Node versions #648

demurgos opened this issue Dec 28, 2017 · 2 comments

Comments

@demurgos
Copy link
Contributor

demurgos commented Dec 28, 2017

Hi,
I am opening this issue following this comment.

Here is Node's maintenance calendar. After iojs was merged back into Node, they started a cyclic maintenance schedule. Today, only the versions >= 4 are maintained by Node.

This library runs CI against Node 0.10, stable, and iojs (Node 3). Sass only runs CI for Node >= 4 but it seems that they are still testing it manually with Node 0.10.

When the older versions of Node reached end of life, there was a move in the ecosystem to adopt the new ES6 syntax. The most visible change is the use of const and let declarators. This means that a large (and still growing) part of npm is no longer usable with old Node versions.
Trying to still support these versions becomes difficult, it will always offer a second-class experience and may also prevent efforts to encourage users to stay up to date.

I would recommend a semver major update, announcing that Node 4+ is required for the gulp plugin and updating the Travis config to use:

node_js:
  - "lts/argon"
  - "lts/boron"
  - "lts/carbon"
  - "node"

Each year, an LTS version will now reach end of life. It would also be good to know what is the policy around it. I'd recommend to not break support for this version for the sake of it, but if an update is needed and requires newer versions, then there should be no big problem to just increase the semver major number and require maintained LTS versions.

@demurgos
Copy link
Contributor Author

After some tests, it appears that node-sass does not support Node < 4. When downloading binaries, it uses request which uses hoek. This module requires Node 4 so node-sass itself requires Node 4.

demurgos added a commit to demurgos/gulp-sass that referenced this issue Dec 28, 2017
demurgos added a commit to demurgos/gulp-sass that referenced this issue Dec 29, 2017
@xzyfer
Copy link
Collaborator

xzyfer commented Apr 5, 2018

Fixed in #667

@xzyfer xzyfer closed this as completed Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants