Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: update to node-sass version 2 beta #159

Merged
merged 1 commit into from
Jan 14, 2015
Merged

WIP: update to node-sass version 2 beta #159

merged 1 commit into from
Jan 14, 2015

Conversation

laurelnaiad
Copy link
Contributor

This is a work in progress. Not to be merged as is....

To decide:

  • pass through change in API such that success callback signature changes? If so, a breaking change notice and docs update are in order
  • does this work with the multitude of options combinations possible?

@laurelnaiad
Copy link
Contributor Author

This turned out to be more basic than I was making it out to be in #147. I guess what's in this branch aside from the obvious move to object-based results from node-sass is a reduction of the logic that was being used to set parameters. If there are corner cases that break from this, I hope we can add tests to demo them and adjust accordingly. My hope is that the reason these reductions seem to work is that node-sass is handling the options combinations better now... we'll see.

Peg node-sass dependency at "2.0.0-beta". node-sass version 2 is still
in beta, be wary of this branch.

Handle object output from node-sass, read `css` and `map` properties,
consistent with node-sass v2 API.

Simplify handling of file/data and sourceComments/sourceMap options.
@laurelnaiad
Copy link
Contributor Author

This, in theory, also addresses what's intended in #154 to fix "#153 (and #148 ?)".

@bradcerasani
Copy link

@laurelnaiad Thanks for your work here - using your fork in a project and the added feature support in 2.0 beta is awesome.

To clarify, what needs to happen before this can be merged? Node-sass 2.0 stable looks to be getting close; if that's the blocker or if there's something else that needs attention, I'm happy to help where I can.

@laurelnaiad
Copy link
Contributor Author

I don't know of anything in particular that needs to happen, aside from node-sass 2.0 being released (and being solid, which I know they're still working on), and the two bullet points in the comment (whether to expose API change to gulp-sass clients and "are all cases" handled question).

@jbrooksuk
Copy link

Is there any further progress on this? We're experiencing issues with our builds when we run on CentOS 6 and Debian Wheezy; cachethq/cachet#275

@awkaiser
Copy link

My team is also looking forward to the node-sass 2.0.0 merge for gulp-sass. Thanks @laurelnaiad!

@dlmanning
Copy link
Owner

Thanks @laurelnaiad! I'm gonna go ahead and publish this to latest on npm. Everyone cross their fingers that node-sass 2.0 is stable-ish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants