-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore includePaths logic #474
Conversation
I believe this was mistakenly removed in dlmanning#353. @eoneill can you shed some light on why you removed this? It has caused issues for users. Fixes dlmanning#469 Fixes dlmanning#473
I think the first half of the fix for #473 is fine. However, I don't think you want to add the file's parent onto the Given directory structure...
Here's a slightly more complex project that demonstrates the issue:
with the following... // [foo/index.scss]
@import "baz/baz"; // [bar/index.scss]
@import "baz/baz"; // [baz/_baz.scss]
@import "partial"; // this is the issue Now, if we prepend the parent directory of the file being compiled, |
I understand it's a bug but it's a bug people rely on and removing has
|
👍 |
I would love to see this fixed in a forthcoming version (since it's a breaking change, it'd have to be a major version bump I'm guessing). Sass, based on my reading, has moved to not automatically including the current (or parent) directory in the load path for a file, so the closer this can get to standard behavior the better. Right now I'm actually working around it by making weird folder structures so load paths don't end up unintentionally preceding each other How would you feel about adding a flag for now that changes the behavior to the fixed version? |
Happy for you to PR this. |
I believe this was mistakenly removed in #353.
@eoneill can you shed some light on why you removed this? It has
caused issues for users.
Fixes #469
Fixes #473