fix: type erros - Cannot find name 'OffscreenCanvas'

dlr-eoc · May 10, 2022 · 33be2fe · 33be2fe
1 parent 83549df
commit 33be2fe
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 12 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+### Bug Fixes
+* **@dlr-eoc/utils-maps:**
+  - Type Errors due to `@types/offscreencanvas`. All modules which use `@dlr-eoc/utils-maps` (which makse use of OffscreenCanvas) have to include `offscreencanvas` in there tsconfig types array. We cannot set this once at the main tsconfig because the types array in tsconfig.spec already [overrides](https://www.typescriptlang.org/tsconfig#extends) the main config.
+
 # [8.1.0](https://github.com/dlr-eoc/ukis-frontend-libraries/tree/v8.1.0) (2022-04-04) (Type for CustomLayer and bug fixes)
 
 ### Features

diff --git a/projects/demo-auth/tsconfig.app.json b/projects/demo-auth/tsconfig.app.json
@@ -3,7 +3,7 @@
   "extends": "../../tsconfig.json",
   "compilerOptions": {
     "outDir": "../../out-tsc/app",
-    "types": []
+    "types": ["offscreencanvas"]
   },
   "files": [
     "src/main.ts",

diff --git a/projects/demo-maps/tsconfig.app.json b/projects/demo-maps/tsconfig.app.json
@@ -4,7 +4,7 @@
   "compilerOptions": {
     "outDir": "../../out-tsc/app",
     "types": [
-      "node"
+      "node", "offscreencanvas"
     ]
   },
   "files": [

diff --git a/projects/map-ol/tsconfig.spec.json b/projects/map-ol/tsconfig.spec.json
@@ -4,7 +4,7 @@
   "compilerOptions": {
     "outDir": "../../out-tsc/spec",
     "types": [
-      "jasmine"
+      "jasmine", "offscreencanvas"
     ]
   },
   "files": [

diff --git a/projects/map-three/tsconfig.spec.json b/projects/map-three/tsconfig.spec.json
@@ -4,7 +4,7 @@
   "compilerOptions": {
     "outDir": "../../out-tsc/spec",
     "types": [
-      "jasmine"
+      "jasmine", "offscreencanvas"
     ]
   },
   "files": [

diff --git a/projects/map-tools/tsconfig.spec.json b/projects/map-tools/tsconfig.spec.json
@@ -4,7 +4,7 @@
   "compilerOptions": {
     "outDir": "../../out-tsc/spec",
     "types": [
-      "jasmine"
+      "jasmine", "offscreencanvas"
     ]
   },
   "files": [

diff --git a/projects/utils-maps/package.json b/projects/utils-maps/package.json
@@ -12,6 +12,7 @@
   "devDependencies": {
     "@angular/platform-browser-dynamic": "0.0.0-PLACEHOLDER-VENDOR",
     "@angular/core": "0.0.0-PLACEHOLDER-VENDOR",
-    "zone.js": "0.0.0-PLACEHOLDER-VENDOR"
+    "zone.js": "0.0.0-PLACEHOLDER-VENDOR",
+    "@types/offscreencanvas": "0.0.0-PLACEHOLDER-VENDOR"
   }
-}
+}
diff --git a/projects/utils-maps/tsconfig.lib.json b/projects/utils-maps/tsconfig.lib.json
@@ -7,11 +7,11 @@
     "declaration": true,
     "declarationMap": true,
     "inlineSources": true,
-    "types": [],
     "lib": [
-      "dom",
-      "es2018"
-    ]
+      "es2018",
+      "dom"
+    ],
+    "types": ["offscreencanvas"]
   },
   "angularCompilerOptions": {
     "skipTemplateCodegen": true,

diff --git a/projects/utils-maps/tsconfig.spec.json b/projects/utils-maps/tsconfig.spec.json
@@ -4,7 +4,7 @@
   "compilerOptions": {
     "outDir": "../../out-tsc/spec",
     "types": [
-      "jasmine"
+      "jasmine", "offscreencanvas"
     ]
   },
   "files": [