test: ng add set skipLibCheck

dlr-eoc · May 16, 2022 · 5f146b4 · 5f146b4
1 parent cfe3da9
commit 5f146b4
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 9 deletions.
diff --git a/projects/core-ui/schematics/ng-add/index.ts b/projects/core-ui/schematics/ng-add/index.ts
@@ -372,6 +372,11 @@ function ruleUpdateTsConfigFile(): Rule {
         json.compilerOptions.paths[p.name] = p.paths;
       }
 
+      // skipLibCheck for libraries like OpenLayers
+      if (!json.compilerOptions.skipLibCheck) {
+        json.compilerOptions.skipLibCheck = true;
+      }
+
       return json;
     });
   };

diff --git a/projects/core-ui/schematics/ng-add/index_spec.ts b/projects/core-ui/schematics/ng-add/index_spec.ts
@@ -3,6 +3,7 @@ import { Schema as WorkspaceOptions } from '@schematics/angular/workspace/schema
 import { Schema as ApplicationOptions, Style } from '@schematics/angular/application/schema';
 import { UkisNgAddSchema } from './schema';
 import * as path from 'path';
+import { TsconfigJSON } from '../schema.tsconfig';
 
 
 const collectionPath = require.resolve(path.join(__dirname, '../collection.json'));
@@ -169,15 +170,23 @@ describe('ng-add', () => {
 
   it('should update the tsconfig file', async () => {
     const tree = await schematicRunner.runSchematicAsync('ng-add', ngAddOptions, appTree).toPromise();
-    const tsconfigFilePath = '/tsconfig.json';
-    const baseTsconfigFilePath = '/tsconfig.base.json';
-    if (tree.exists(baseTsconfigFilePath)) {
-      const tsconfigFile = JSON.parse(tree.readContent(baseTsconfigFilePath));
-      expect('@dlr-eoc/*' in tsconfigFile.compilerOptions.paths).toBe(true);
-    } else {
-      const tsconfigFile = JSON.parse(tree.readContent(tsconfigFilePath));
-      expect('@dlr-eoc/*' in tsconfigFile.compilerOptions.paths).toBe(true);
-    }
+    const configs = ['/tsconfig.json', '/tsconfig.base.json'];
+    configs.forEach(configFilePath => {
+      if (tree.exists(configFilePath)) {
+        const tsconfigFile = JSON.parse(tree.readContent(configFilePath)) as TsconfigJSON;
+        const paths = tsconfigFile?.compilerOptions?.paths;
+        expect(paths).toBeTruthy();
+        if (paths) {
+          expect('@dlr-eoc/*' in paths).toBe(true);
+        }
+
+        const skipLibCheck = tsconfigFile?.compilerOptions?.skipLibCheck;
+        expect(skipLibCheck).toBeTruthy();
+        if (skipLibCheck !== undefined) {
+          expect(skipLibCheck).toBe(true);
+        }
+      }
+    });
   });
 
   it('should update html files', async () => {