Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and documentation #130

Merged
merged 21 commits into from
May 20, 2022
Merged

Update dependencies and documentation #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
cfaf539
test: attribution on VectorLayer
boeckMt May 9, 2022
aa70e36
test: postrender blend-mode
boeckMt May 9, 2022
13735d2
build: update deps
boeckMt May 9, 2022
95d7724
build: run ng core migrate
boeckMt May 9, 2022
940e526
build: run ng cli migrate
boeckMt May 9, 2022
5b13a5f
build: fix ng serve and remove parse from url
boeckMt May 9, 2022
83549df
fix: type error AbstractControl from FormGroup
boeckMt May 10, 2022
33be2fe
fix: type erros - Cannot find name 'OffscreenCanvas'
boeckMt May 10, 2022
3a49e27
docs: adjust dev readme update dependencies
boeckMt May 16, 2022
cfe3da9
BREAKING CHANGE: set BC for angular and mapbox-style update
boeckMt May 16, 2022
5f146b4
test: ng add set skipLibCheck
boeckMt May 16, 2022
55e7700
fix: type error access of index signature
boeckMt May 16, 2022
68abb5b
feat: add library to the dependencies on ng-add
boeckMt May 16, 2022
2df4e23
test: fix resolve path - Module not found
boeckMt May 16, 2022
da1260d
ci: add matching npm for node
boeckMt May 16, 2022
99d2f8e
ci: set node version in workflows to fit Angular CLI requires
boeckMt May 16, 2022
1f4a91a
ci: sync package and lock for node and npm version
boeckMt May 16, 2022
dab8a01
ci: fix npm audit
boeckMt May 16, 2022
3b95633
docs: split readme and dev for core-ui
boeckMt May 18, 2022
80a6fa8
refactor: remove postrender blend-mode test from demo
boeckMt May 18, 2022
c0c4b68
docs: fix typo
boeckMt May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/package-main-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
git checkout ${{ needs.checkTitelTag.outputs.VERSION_TAG }}
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
- run: rm -f .npmrc
- uses: ./.github/actions/check-tag-on-npm
with:
Expand All @@ -88,7 +88,7 @@ jobs:
git checkout ${{ needs.checkTitelTag.outputs.VERSION_TAG }}
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
- name: build
run: |
npm ci
Expand Down Expand Up @@ -146,7 +146,7 @@ jobs:
path: dist
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
registry-url: https://npm.pkg.github.com/
scope: "@dlr-eoc"
- run: npm ci
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
path: dist
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
registry-url: https://registry.npmjs.org/
scope: "@dlr-eoc"
- run: npm ci
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/package-pre-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
- run: rm -f .npmrc
- uses: ./.github/actions/check-tag-on-npm
with:
Expand All @@ -41,7 +41,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
- uses: ./.github/actions/build-test
- name: Archive dist artifacts
uses: actions/upload-artifact@v2
Expand All @@ -61,7 +61,7 @@ jobs:
path: dist
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
registry-url: https://npm.pkg.github.com/
scope: "@dlr-eoc"
- run: npm ci
Expand Down Expand Up @@ -94,7 +94,7 @@ jobs:
path: dist
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool thing that we're moving up to node16. I think I remember that older versions of node/npm would create an old-style package-lock v1.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think this was between npm 6 and 7.
We only have one Issue to fix for the publish step #129 where we use npm 6. But we don't install anything here, it's just for the publish command so I hope this is still working with the newer node version.

registry-url: https://registry.npmjs.org/
scope: "@dlr-eoc"
- run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,6 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 15
node-version: 16
- uses: ./.github/actions/test
- uses: ./.github/actions/build
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ speed-measure-plugin*.json
.history/*

# misc
/.angular/cache
/.sass-cache
/connect.lock
/coverage
Expand Down
10 changes: 10 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@

### Breaking Changes
* **@dlr-eoc:**
- Update angular from `^12.2.5` to `^13.3.5`
- Update ol-mapbox-style from `^7.0.0` to `^8.0.7`

### Bug Fixes
* **@dlr-eoc/utils-maps:**
- Type Errors due to `@types/offscreencanvas`. All modules which use `@dlr-eoc/utils-maps` (which makse use of OffscreenCanvas) have to include `offscreencanvas` in there tsconfig types array. We cannot set this once at the main tsconfig because the types array in tsconfig.spec already [overrides](https://www.typescriptlang.org/tsconfig#extends) the main config.

# [8.1.0](https://github.com/dlr-eoc/ukis-frontend-libraries/tree/v8.1.0) (2022-04-04) (Type for CustomLayer and bug fixes)

### Features
Expand Down
6 changes: 3 additions & 3 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,12 @@
- Create a new branch for your feature specific changes based on master: e.g. `git checkout -b feature-XXX`
- Install dependencies: `npm install`

## Note
- all versions in package.json should be fixed!
- reserve time in sprint or before a sprint to upgrade versions and then to test and fix broken dependencies. (similar to hardware upgrades)
## Update dependencies
- reserve time in sprint or before a sprint to upgrade versions and then to test and fix broken dependencies.
- check for new versions `npm outdated -l` and `ng update`
- update versions `npm update <pkg>` and `ng update <pkg>`
- make angular migrations manually `ng update @angular/cli --from <version> --to <version> --migrate-only` and `ng update @angular/core --from <version> --to <version> --migrate-only`
- an update of a `major` version in the dependencies should introduce a **BREAKING CHANGE!**

## General Development Workflow

Expand Down
Loading