Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop PreferencesFxFormRenderer from shrinking labels #449

Merged
merged 1 commit into from
Apr 28, 2023
Merged

Stop PreferencesFxFormRenderer from shrinking labels #449

merged 1 commit into from
Apr 28, 2023

Conversation

VirtualTim
Copy link
Contributor

This change stops the right column from shrinking the left.
Hopefully the screenshots clarify the behaviour.

PR Checklist

  • There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open an issue first and wait for approval before working on it.
  • The code follows the Google Java Style Guide.
  • JavaDoc is added / changed for public methods.
  • An example of the new feature is added to the demos.
  • Documentation of the feature is included in the README.
  • Tests for the changes are included.

What is the current behavior?

image

What is the new behavior?

image

@VirtualTim
Copy link
Contributor Author

Should I also update CHANGELOG.md to note this?

@VirtualTim
Copy link
Contributor Author

@dlemmermann
There's a few PRs that I've opened here since February. Are you able to take a look at them?

@dlemmermann dlemmermann merged commit 64aeb35 into dlsc-software-consulting-gmbh:master-11 Apr 28, 2023
@dlemmermann
Copy link
Collaborator

Should I also update CHANGELOG.md to note this?

Yes please.

@VirtualTim
Copy link
Contributor Author

Should I also update CHANGELOG.md to note this?

Yes please.

Done - #450.

@VirtualTim VirtualTim deleted the patch-5 branch April 29, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VirtualTim @dlemmermann