Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Category icons #52

Merged
merged 4 commits into from
Jan 20, 2019
Merged

Add support for Category icons #52

merged 4 commits into from
Jan 20, 2019

Conversation

ArvidNy
Copy link
Contributor

@ArvidNy ArvidNy commented Jan 12, 2019

Fix #51

martinfrancois
martinfrancois suggested changes Jan 13, 2019
View reviewed changes
Copy link
Contributor

@martinfrancois martinfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great contribution! 👍
Upon first look, the implementation seems to be fine.
Can you please also add an example to the demo and add documentation in the Readme? Thanks!

@ArvidNy
Add demo example of a Category icon
4b268d8 
Add Readme documentation
Cleanup code
@ArvidNy
Copy link
Contributor Author

ArvidNy commented Jan 14, 2019

Wasn't sure where in the Readme you wanted this, so I just added this as a note for now.

@martinfrancois
Copy link
Contributor

Thanks a lot! Now it's perfect 👍
I just changed the way the icon is accessed in the demo, as we prefer to get it by the resource, instead of specifying the absolute path, I hope that's okay for you!

@martinfrancois martinfrancois merged commit e650f69 into dlsc-software-consulting-gmbh:develop Jan 20, 2019
ArvidNy added a commit to ArvidNy/PreferencesFX that referenced this pull request Jan 21, 2019
@ArvidNy
Merge pull request #1 from dlemmermann/develop
d6cc2d7 
Merge pull request dlsc-software-consulting-gmbh#52 from ArvidNy/develop
@martinfrancois martinfrancois mentioned this pull request Jul 19, 2019
Closed
@martinfrancois martinfrancois added the enhancement New feature or request label Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfrancois martinfrancois martinfrancois approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArvidNy @martinfrancois