Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add option to auto-expand category #77

Merged
merged 3 commits into from
Jul 20, 2019
Merged

Feature: Add option to auto-expand category #77

merged 3 commits into from
Jul 20, 2019

Conversation

p1r9t3
Copy link

@p1r9t3 p1r9t3 commented Jun 24, 2019

No description provided.

martinfrancois
martinfrancois suggested changes Jul 19, 2019
View reviewed changes
Copy link
Contributor

@martinfrancois martinfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution! This feature is a nice addition in my opinion!
Can you please add an example on how to use it to the demos and extend the Readme to contain an explanation of this feature?

preferencesfx/src/main/java/com/dlsc/preferencesfx/model/Category.java Outdated Show resolved Hide resolved
@p1r9t3
Copy link
Author

p1r9t3 commented Jul 20, 2019

Hi, thanks for the contribution! This feature is a nice addition in my opinion!
Can you please add an example on how to use it to the demos and extend the Readme to contain an explanation of this feature?

Done and submitted. I added to the README and to some of the demos.

martinfrancois
martinfrancois approved these changes Jul 20, 2019
View reviewed changes
Copy link
Contributor

@martinfrancois martinfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks for making the changes so quickly, well done!

@martinfrancois martinfrancois merged commit c1de1d8 into dlsc-software-consulting-gmbh:develop Jul 20, 2019
@martinfrancois martinfrancois added the enhancement New feature or request label Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfrancois martinfrancois martinfrancois approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p1r9t3 @martinfrancois @nerd-king