Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Snowflake docs #1747

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Update Snowflake docs #1747

merged 1 commit into from
Aug 28, 2024

Conversation

akelad
Copy link
Contributor

@akelad akelad commented Aug 26, 2024

Our docs contained the wrong information, stage files in Snowflake are kept by default: https://dlthub.com/docs/api_reference/destinations/impl/snowflake/factory#snowflake-objects

Noticed by a community member: https://dlthub-community.slack.com/archives/C04DQA7JJN6/p1724413082471379

@akelad akelad requested a review from VioletM August 26, 2024 14:33
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 2788235
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/66cc923e6e8f090008f31f60
😎 Deploy Preview https://deploy-preview-1747--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@akelad
Copy link
Contributor Author

akelad commented Aug 26, 2024

@VioletM as the Snowflake expert would be great if you can check that I've formatted the config right hehe

@@ -136,7 +136,12 @@ If you set the [`replace` strategy](../../general-usage/full-loading.md) to `sta
recreated with a [clone command](https://docs.snowflake.com/en/sql-reference/sql/create-clone) from the staging tables.

## Data loading
The data is loaded using an internal Snowflake stage. We use the `PUT` command and per-table built-in stages by default. Stage files are immediately removed (if not specified otherwise).
The data is loaded using an internal Snowflake stage. We use the `PUT` command and per-table built-in stages by default. Stage files are kept by default, unless specified otherwise via the `keep_staged_files` parameter:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is true only for Snowlake named or external stage (s3/azure/gcp). In this case, dlt will keep the latest files by default unless it says otherwise via keep_staged_files parameter. If people does not provide any stage to dlt, it uses table stage, and I don't know what happened to these files, but I don't think you can access them at all

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh ok so I guess I should edit this to say the stage files are removed unless you explicitly define a stage?

@akelad akelad merged commit 817d51d into devel Aug 28, 2024
47 checks passed
@rudolfix rudolfix deleted the akelad-patch-1 branch October 21, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants