docs: fix absolute links #1834
Merged
docs: fix absolute links #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
VioletM
requested changes
Sep 18, 2024
| @@ -220,7 +220,7 @@ To enable this, GCS provides an S3 | |||
| compatibility mode that emulates the S3 API, allowing ClickHouse to access GCS buckets via its S3 integration. | |||
|
|
|||
| For detailed instructions on setting up S3-compatible storage with dlt, including AWS S3, MinIO, and Cloudflare R2, refer to | |||
| the [dlt documentation on filesystem destinations](https://dlthub.com/docs/dlt-ecosystem/destinations/filesystem#using-s3-compatible-storage). | |||
| the [dlt documentation on filesystem destinations](/dlt-ecosystem/destinations/filesystem#using-s3-compatible-storage). | |||
There was a problem hiding this comment.
I think the link should be relative to the current page, otherwise if I'm on devel docs and I click the link it will jump to the latest version.
Suggested change
| the [dlt documentation on filesystem destinations](/dlt-ecosystem/destinations/filesystem#using-s3-compatible-storage). | |
| the [dlt documentation on filesystem destinations](./filesystem#using-s3-compatible-storage). |
VioletM
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change absolute links in docs to relative ones.
Adds a new test to ensure that there are no absolute or devel links in the docs md links