Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: UUIDs are not an unknown data type (logging) #1914

Merged
merged 1 commit into from
Oct 2, 2024
Merged

fix: UUIDs are not an unknown data type (logging) #1914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dlt/sources/sql_database/schema_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def sqla_col_to_column_schema(
if hasattr(sqltypes, "Uuid") and isinstance(sql_t, sqltypes.Uuid):
# we represent UUID as text by default, see default_table_adapter
col["data_type"] = "text"
if isinstance(sql_t, sqltypes.Numeric):
elif isinstance(sql_t, sqltypes.Numeric):
# check for Numeric type first and integer later, some numeric types (ie. Oracle)
# derive from both
# all Numeric types that are returned as floats will assume "double" type
Expand Down
Loading