Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1897 support https endpoints clickhouse #1931

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Oct 7, 2024

Description

See linked ticket

Copy link

netlify bot commented Oct 7, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 7664713
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/670d93c3cacc1a00084f8e11

@sh-rp sh-rp marked this pull request as ready for review October 7, 2024 10:32
@sh-rp
Copy link
Collaborator Author

sh-rp commented Oct 11, 2024

@rudolfix the reporter of this ticket did not get back to me. I added some simple tests and a docs entry. I don't think we should deduplicate forward slashes as requested, afaik s3://bucket/folder/subfolder and s3://bucket/folder//subfolder are separate locationns

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but the test didn't run on CI. maybe it is not included? if this is like you intended then merge this

@sh-rp sh-rp merged commit 829ed76 into devel Oct 15, 2024
57 of 61 checks passed
@rudolfix rudolfix deleted the fix/1897-support-https-endpoints-clickhouse branch October 21, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect S3 url when using Digital Ocean Spaces as staging and Clickhouse as destination
2 participants