SQL Database: Support including/excluding NULL cursor values #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rudolfix
requested changes
Oct 13, 2024
dlt/sources/sql_database/helpers.py
Outdated
| @@ -13,6 +13,8 @@ | |||
| ) | |||
| import operator | |||
|
|
|||
| from sqlalchemy import and_, or_ | |||
There was a problem hiding this comment.
could you import via our lib, not directly?
dlt/sources/sql_database/helpers.py
Outdated
| @@ -96,9 +100,15 @@ def _make_query(self) -> SelectAny: | |||
| return query # type: ignore[no-any-return] | |||
|
|
|||
| if self.last_value is not None: | |||
| query = query.where(filter_op(self.cursor_column, self.last_value)) | |||
| where_and_clauses = [filter_op(self.cursor_column, self.last_value)] | |||
There was a problem hiding this comment.
queries are OK. should exclude option be independent from if self.last_value is not None:? I think so. we could skip NONE also on initial load
steinitzu
force-pushed
the
sql-database-include-none-cursor-value
branch
from
091548f to
dfa300e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Respect the
on_cursor_value_missingincremental setting in sqlalchemy source.Generating WHERE clause equvialent to:
I'm not sure if the
excludecase needs to be handled but thought I'd include explicitly anyway in case any databases interpret>= NULLdifferently.Related Issues
Additional Context