Updated databricks destination documentation #1984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
burnash
requested changes
Oct 24, 2024
| * [JSONL](../file-formats/jsonl.md) supported when staging is enabled (see limitations below). | ||
| * [Parquet](../file-formats/parquet.md) supported when staging is enabled. | ||
|
|
||
| * [parquet](../file-formats/parquet.md) supported when staging is enabled. |
There was a problem hiding this comment.
Suggested change
| * [parquet](../file-formats/parquet.md) supported when staging is enabled. | |
| * [Parquet](../file-formats/parquet.md) supported when staging is enabled. |
Parquet should be capitalized in the sentence because it is the name of a specific file format. Proper nouns, such as the names of file formats, should be capitalized.
There was a problem hiding this comment.
yes, updated. Thanks!
| * [Parquet](../file-formats/parquet.md) supported when staging is enabled. | ||
|
|
||
| * [parquet](../file-formats/parquet.md) supported when staging is enabled. | ||
| * [jsonl](../file-formats/jsonl.md) supported when staging is enabled (see limitations below). |
There was a problem hiding this comment.
Suggested change
| * [jsonl](../file-formats/jsonl.md) supported when staging is enabled (see limitations below). | |
| * [jsonl](../file-formats/jsonl.md) supported when staging is enabled (see limitations below). |
Same as Parquet, "JSONL" should also be capitalized, as it is an acronym for "JSON Lines."
| @@ -128,15 +128,17 @@ See [staging support](#staging-support) for authentication options when `dlt` co | |||
| All write dispositions are supported. | |||
|
|
|||
| ## Data loading | |||
| Data is loaded using `INSERT VALUES` statements by default. | |||
| To load data into Databricks, you must set up a staging filesystem by configuring an Amazon S3 or Azure Blob Storage bucket. `parquet` is the default file format used for data uploads. As an alternative to `parquet`, you can switch to using `JSONL`. | |||
There was a problem hiding this comment.
There's no need to mark Parquet and JSONL as code here as you're referring to file formats.
burnash
deleted the
docs/1953-update-databricks-destination-documentation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Databricks documentation suggests that staging is optional for the destination. However, it's important to clarify that Databricks requires a staging destination.
Related Issues