Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the deprecation warning in .common.configuration.container #2025

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Nov 5, 2024

Fixes #2015

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit ef64ee9
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/6729d86abe58800008533b2f
😎 Deploy Preview https://deploy-preview-2025--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@burnash burnash requested a review from sh-rp November 5, 2024 08:34
Copy link
Collaborator

@sh-rp sh-rp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, seems to be around since before python 3.9

@burnash
Copy link
Collaborator Author

burnash commented Nov 5, 2024

looks good, seems to be around since before python 3.9

Even earlier: https://docs.python.org/3.8/library/threading.html#threading.Thread
So there's no need to handle anything for 3.8.

@burnash burnash merged commit e6bd8ea into devel Nov 5, 2024
61 checks passed
@burnash burnash deleted the fix/2015-deprecation-warning branch November 5, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation Warning in Multithreading
2 participants