disable sftp + delta test #2052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
sh-rp
force-pushed
the
fix/deltalake-alternate
branch
2 times, most recently
from
c0e65c7 to
ac9e6b0
Compare
sh-rp
changed the title
sh-rp
changed the title
sh-rp
changed the title
rudolfix
requested changes
Nov 12, 2024
| @@ -118,6 +118,9 @@ jobs: | |||
| - name: Install pyarrow | |||
| run: poetry install --no-interaction -E duckdb -E cli -E parquet --with sentry-sdk | |||
|
|
|||
| - name: Ensure pyarrow 15 | |||
| run: poetry run pip install pyarrow==15.0.2 | |||
|
|
|||
There was a problem hiding this comment.
OK! just make sure that this line:
poetry install --no-interaction -E duckdb -E cli -E parquet -E deltalake -E sql_database --with sentry-sdk,pipeline,sources
is not installing arrow 17 again. I see delta is being installed so probably that happens... maybe we should split testing of the lib to a separate step where we install delta
There was a problem hiding this comment.
yeah good point. I think every call to poetry install has the potential to change this. I have updated the workflow not fix this, but I am not quite sure how you would set it up tbh.
sh-rp
force-pushed
the
fix/deltalake-alternate
branch
from
e6a6feb to
f2156d0
Compare
sh-rp
force-pushed
the
fix/deltalake-alternate
branch
from
f2156d0 to
71931df
Compare
sh-rp
force-pushed
the
fix/deltalake-alternate
branch
from
71931df to
8250633
Compare
rudolfix
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The lancedb PR last week broke our CI. Fixes done here are: