Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the usage of escaped JSONPath in incremental cursors in sql_database #2077

Merged
merged 3 commits into from
Nov 23, 2024

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Nov 20, 2024

Fixes #2061

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit f52cbc0
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/673de5aa7b8ff60008cdab1a
😎 Deploy Preview https://deploy-preview-2077--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@burnash burnash requested review from rudolfix and sh-rp November 20, 2024 07:47
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thx for fixing tech debt and the tests

@rudolfix rudolfix merged commit 6e0510a into devel Nov 23, 2024
59 checks passed
@rudolfix rudolfix deleted the fix/2061-escape-special-chars-in-sql_database branch November 23, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL table incremental escape $ in column name for cursor_path
2 participants