Fix/2089 support sets for pyarrow backend #2090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
master merge for 1.0.0 release
Merge broken docs fix to master
master merge for 1.1.0 release
master merge for 1.2.0 release
master merge for 1.3.0 release
master merge for 1.4.0 release
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
karakanb
force-pushed
the
fix/2089-support-sets-for-pyarrow-backend
branch
from
a9930a1 to
816b7d3
Compare
|
@karakanb LGTM! do you have any tests for that in your code base? does it solve your problem? we do not have MySQL test setup for the sql source (only for the destination). |
|
I only have integration tests in ingestr, unfortunately no unit tests that might cover this. I have manually tested this and it solved the problem. |
rudolfix
approved these changes
Nov 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue with mysql set fields on pyarrow backend.
Related Issues
Open Questions
There's also a similar issue with using sqlalchemy backend, it requires a custom type adapter callback function to be useful. should it be handled properly inside dlt by default? I couldn't find a common sqltype to represent dicts, happy to fix it if you have any recommendations on how to fix it.