Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] crash when assigning to a non-existant PR #527

Open
jpagh opened this issue Feb 14, 2025 · 1 comment · May be fixed by #533
Open

[BUG] crash when assigning to a non-existant PR #527

jpagh opened this issue Feb 14, 2025 · 1 comment · May be fixed by #533
Labels
bug Something isn't working

Comments

@jpagh
Copy link

jpagh commented Feb 14, 2025

Describe the bug
I get a Caught panic: runtime error: invalid memory address or nil pointer dereference when pressing a on the "My Pull Requests screen when I don't have any pull requests.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'My Pull Requests' (first screen)
  2. Click the a key
  3. See crash and error message

Expected behavior
Not to crash. I was trying gh-dash for the first time, couldn't figure out how to change the screen to see "Issues" and hit a.

Screenshots
Image

Desktop (please complete the following information):

  • OS: Windows 11 23H2
  • Terminal: Windows Terminal 1.22.10352.0
  • Shell: Powershell 7.5.0
  • Prompt: Starship 1.22.1
@jpagh jpagh added the bug Something isn't working label Feb 14, 2025
liyujun-dev added a commit to liyujun-dev/gh-dash that referenced this issue Feb 20, 2025
@liyujun-dev
fix: missing nil pointer check on PRs and Issues view dlvhdr#527
6a8ddf7
@liyujun-dev
Copy link
Contributor

You can press s to switch between different views. This bug should be resolved by adding a nil pointer check on the pr or issue data.

@liyujun-dev liyujun-dev mentioned this issue Feb 20, 2025
Closed
liyujun-dev added a commit to liyujun-dev/gh-dash that referenced this issue Feb 21, 2025
@liyujun-dev
fix: missing nil pointer check on PRs and Issues view dlvhdr#527
5f20e3e
liyujun-dev added a commit to liyujun-dev/gh-dash that referenced this issue Feb 21, 2025
@liyujun-dev
fix: missing nil pointer check on PRs and Issues view dlvhdr#527
d79763f
@liyujun-dev liyujun-dev linked a pull request Feb 21, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@liyujun-dev @jpagh