replace all log.Fatalf's with plain log and let upper layer die

log.Fatalf kills the process it is running, as a library, we want to give this control flow to the consumer of our library
dmacvicar · Sep 23, 2024 · 09ed957 · 09ed957
1 parent 0856861
commit 09ed957
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/libvirt/data_source_libvirt_node_device_info.go b/libvirt/data_source_libvirt_node_device_info.go
@@ -491,7 +491,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
 
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device generic into deviceXML: %#v", deviceXML)
 
@@ -501,7 +501,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DeviceSystem{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device system XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device system XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device system into deviceXML: %v", deviceXML)
 
@@ -531,7 +531,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DevicePCI{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device pci XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device pci XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device pci into deviceXML: %v", deviceXML)
 
@@ -578,7 +578,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DeviceUSBDevice{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device usb_device XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device usb_device XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device usb_device into deviceXML: %v", deviceXML)
 
@@ -603,7 +603,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DeviceUSB{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device usb XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device usb XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device usb into deviceXML: %v", deviceXML)
 
@@ -623,7 +623,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DeviceStorage{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device storage XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device storage XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device storage into deviceXML: %v", deviceXML)
 
@@ -646,7 +646,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DeviceNet{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device net XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device net XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device net into deviceXML: %v", deviceXML)
 
@@ -672,7 +672,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DeviceSCSI{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device scsi XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device scsi XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device scsi into deviceXML: %v", deviceXML)
 
@@ -693,7 +693,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DeviceSCSIHost{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device scsi_host XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device scsi_host XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device scsi_host into deviceXML: %v", deviceXML)
 
@@ -711,7 +711,7 @@ func resourceLibvirtNodeDeviceInfoRead(d *schema.ResourceData, meta interface{})
  deviceXML := DeviceDRM{}
  err = xml.Unmarshal([]byte(xmlDesc), &deviceXML)
  if err != nil {
- log.Fatalf("failed to unmarshal device drm XML into deviceXML: %v", err)
+ log.Printf("[ERROR] failed to unmarshal device drm XML into deviceXML: %v", err)
  }
  log.Printf("[DEBUG] Parsed device drm into deviceXML: %v", deviceXML)