-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add volume_attachment resources or equivalent #79
Comments
Maybe we can find a solution in the context proposed in #46 ... |
@inercia I do not think this is related. Besides the fact I would agree with closing #46 the RFC is about embedding parameters for the ephemeral, "must-have" OS basic volume in the domain resource, while this is about extra "data" disks which might or might be there - hence in variable quantity. |
My proposal would be to add a This could even supersede the current |
See dmacvicar#79 for discussion.
See dmacvicar#79 for discussion.
Note this comment about |
Asked HashiCorp if this is a core issue or by design. |
I would take other providers as a template, Scaleway got a comparable approach. |
OK, seems it's possible to fix this on our side, accepting maps and not objects for the https://gitter.im/hashicorp-terraform/Lobby?at=581793b5806316005dde1c80 I will probably attempt a pull request soon. |
Correct solution should be, from my point of view, #83 |
PR merged, closing. |
I want to create a libvirt domain with a variable number of attached volumes (case in point is one main disk always present, and one optional data disk).
Currently this is not possible in any way I tried. Although the
disk
attribute looks like a map it cannot be passed parameters (the following does not work):Where
var.disks
is a map with avolume_id
key and a correct id value. In fact not even the following works:We get the following error on 0.7.7:
Error reading config for libvirt_domain[domain]: At 31:11: root.disk[0]: not an object type for map (*ast.LiteralType)
It would be great to have a way around this, eg:
disk_ids
plain list of ids instead of a list of maps/objectsdisk
variable.Thanks in advance!!!
The text was updated successfully, but these errors were encountered: