Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not panic on invalid SSH key #1103

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

scabala
Copy link
Contributor

@scabala scabala commented Sep 23, 2024

Since this is a single word change, I dare to not provide test case but I will if you ask me.

Closes #1078

@scabala scabala changed the title Fix/issue 1078 Do not panic on invalid SSH key Sep 23, 2024
@scabala
Copy link
Contributor Author

scabala commented Sep 23, 2024

FYI @dmacvicar @rabin-io

@dmacvicar dmacvicar added Bug Important (Wanted) Feature or contribution desired to be had and merged labels Sep 23, 2024
@dmacvicar dmacvicar merged commit 72a3214 into dmacvicar:main Oct 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Important (Wanted) Feature or contribution desired to be had and merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libvirt provider fails with ssh.publicKeyCallback.auth if the SSH key is invalid
2 participants