Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use qemu-agent variable as terraform variable for domain #377

Merged
merged 6 commits into from
Aug 27, 2018

Conversation

MalloZup
Copy link
Collaborator

@MalloZup MalloZup commented Aug 27, 2018

fix #374

@MalloZup
Copy link
Collaborator Author

for sumaform the behaviour is invisible for users, see moio/sumaform@740c5ab

@MalloZup MalloZup requested a review from inercia August 27, 2018 12:18
@moio
Copy link
Collaborator

moio commented Aug 27, 2018

Note also that it is possible to emulate the old behavior since Terraform allows to set variables via environment variables, in case there is a actual need for those:

https://www.terraform.io/docs/configuration/environment-variables.html#tf_var_name

@MalloZup
Copy link
Collaborator Author

@dmacvicar feel free to review it, tia 🌻

Copy link
Owner

@dmacvicar dmacvicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach more than the old one. It is a breaking change, but hey, we are still 0.X

@MalloZup MalloZup merged commit c1221a7 into dmacvicar:master Aug 27, 2018
@MalloZup MalloZup deleted the net-qemu-agentvar branch September 10, 2018 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bridge mode follow-up issue from #373 qemu-agent
3 participants