-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Use upstream DOMAIN_INTERFACE_ADDRESSES_SRC_AGENT #432
Conversation
c768dec
to
3e7abbd
Compare
1bc98a0
to
01cc5dd
Compare
c83a639
to
e7cfa90
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't see how the agent source is used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK everything is ok now
44bb91c
to
9c18e1f
Compare
6079c53
to
8d8c72a
Compare
a16a1c2
to
7a0b188
Compare
7a0b188
to
3f59610
Compare
@MalloZup can you please post an example of the configuration that would fail? (no need for it to be real, just an example, to understand it better) |
i prefer to concetrate on other issues which will bring more value. |
What does this PR:
In past we used
domain.QemuAgentCommand
for getting the Interfaces via qemu-agent.Now we are using
domain.ListAllInterfaceAddresses(libvirt.DOMAIN_INTERFACE_ADDRESSES_SRC_LEASE
additionally as you can see, we get more simpler codebase with the new function from upstream.
for domains which are
down
we just skip. This was also the behaviour from libvirt-apiWe still need a loop function with timeouts because otherwise we might endup in a situation where the QEMU-AGENT is installed but not already setup. So we need to wait and retry for a delay of time.
If we don't have the timeout with the loop we will get at 1st try error:
Guest agent is not responding: QEMU guest agent is not connected