Fix small issues due latest change

[MalloZup]

make test doesn't work anymore.

The go covermode need seperate module at once..

I am checking if the terraform version has other things

[MalloZup]

this will run the unit-test we don\t need for such feature a profile.cov

[MalloZup]

we need to split in 2 otherwise it doesn't work

[wking]

we need to split in 2 otherwise it doesn't work

What error do you see? For me:

$ git describe --always --abbrev=40 --dirty
fe5737439750f97f4e1816cf59e90066529f2e72
$ make test
go test -v -covermode=count -coverprofile=profile.cov . ./libvirt
=== RUN   TestPrintVersion
--- PASS: TestPrintVersion (0.32s)
PASS
coverage: 62.2% of statements
ok  	github.com/dmacvicar/terraform-provider-libvirt	0.335s	coverage: 62.2% of statements
...
=== RUN   TestAccLibvirtCloudInit_CreateCloudInitDiskAndUpdate
--- FAIL: TestAccLibvirtCloudInit_CreateCloudInitDiskAndUpdate (0.00s)
panic: interface conversion: interface {} is nil, not *libvirt.Client [recovered]
	panic: interface conversion: interface {} is nil, not *libvirt.Client

goroutine 67 [running]:
testing.tRunner.func1(0xc420460000)
	/home/trking/.local/go/src/testing/testing.go:742 +0x29d
panic(0xdfdea0, 0xc420446180)
	/home/trking/.local/go/src/runtime/panic.go:502 +0x229
github.com/dmacvicar/terraform-provider-libvirt/libvirt.TestAccLibvirtCloudInit_CreateCloudInitDiskAndUpdate(0xc420460000)
	/home/trking/.local/lib/go/src/github.com/dmacvicar/terraform-provider-libvirt/libvirt/resource_libvirt_cloud_init_test.go:24 +0x127b
testing.tRunner(0xc420460000, 0xf5d7b0)
	/home/trking/.local/go/src/testing/testing.go:777 +0xd0
created by testing.(*T).Run
	/home/trking/.local/go/src/testing/testing.go:824 +0x2e0
FAIL	github.com/dmacvicar/terraform-provider-libvirt/libvirt	24.031s
make: *** [test] Error 1

But I see that same panic on your 21c6b8b too.

[MalloZup]

Yop the panic is not important. Actually it should not be scheduled that test in the unittest but in acceptance only I still dunno why it land there

I have an error which complain about the cover profile, which golang version are you using at moment? I think that the thing is maybe changed with higher versions of golang..

[wking]

I have an error which complain about the cover profile, which golang version are you using at moment? I think that the thing is maybe changed with higher versions of golang..

$ go version
go version go1.10.3 linux/amd64

[MalloZup]

@wking i was thinking we agreed to remove the nil and use the local kvm as default value.

What prevented you for doing it? it was just a thing you forgot ? tia

[wking]

@wking i was thinking we agreed to remove the nil and use the local kvm as default value.

What prevented you for doing it?

I just left all that libvirt/ stuff alone in #444 ;). But I think we want to leave the nil here to punt defaulting to the C library (see here and the links from the 91d0e45 commit message).

[wking]

And if you either fall back to the C library defaults or add your own non-nil default, you can probably drop Required: true.

[MalloZup]

Ok thx for links

[MalloZup]

@wking this the error ( i got a terminal meanwhile :) )

go test -v -covermode=count -coverprofile=profile.cov . ./libvirt
cannot use test profile flag with multiple packages
make: *** [Makefile:12: test] Error 1

go version go1.9.7 linux/amd64

[MalloZup]

yop indeed this was fixed in 1.10 version..

golang/go#6909

[MalloZup]

@wking i opened a small issue as follow-up for later.

Imho we can have it later when all os-distros have the fix #454