Speed up terraform apply when domains are shutdown #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I almost always keep several domains shutdown when working, this makes terraform apply pretty slow.
Reason is we currently try to get an address from
qemu-gairrespective of the domain state - obviously if the domain is shut down that will eventually time out.Ironically, we do avoid querying the libvirt API (in case
qemu-gais not used) when the domain is not running - in my understanding the check for the state should be the same irrespective of the usage ofqemu-ga.This patch just moves the check a few lines before it was.