Skip to content

Commit

Permalink
change: [M3-8957] - Allow Docker registry to be overridden when build…
Browse files Browse the repository at this point in the history
…ing Cloud images (linode#11360)

* Allow Docker registry to be overridden via `IMAGE_REGISTRY` arg

* Add changeset
  • Loading branch information
jdamore-linode authored and dmcintyr-akamai committed Jan 9, 2025
1 parent af8309b commit 04b295d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@linode/manager": Tech Stories
---

Add `IMAGE_REGISTRY` Docker build argument ([#11360](https://github.com/linode/manager/pull/11360))
8 changes: 6 additions & 2 deletions packages/manager/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
# Registry to use when pulling images.
# Defaults to Docker Hub, but can be overriden to point to another registry if needed.
ARG IMAGE_REGISTRY=docker.io

# Node.js base image for Cloud Manager CI tasks.
#
# Extends from the Node.js base image that corresponds with our latest supported
# version of Node, and includes other tools that we rely on like pnpm and bun.
FROM node:20.17-bullseye-slim as nodejs-cloud-manager
FROM ${IMAGE_REGISTRY}/node:20.17-bullseye-slim as nodejs-cloud-manager
RUN npm install -g pnpm bun

# `manager`
Expand All @@ -28,7 +32,7 @@ CMD yarn start:manager:ci
#
# Builds an image containing Cypress and miscellaneous system utilities required
# by the tests.
FROM cypress/included:13.11.0 as e2e-build
FROM ${IMAGE_REGISTRY}/cypress/included:13.11.0 as e2e-build
RUN npm install -g pnpm bun
USER node
WORKDIR /home/node/app
Expand Down

0 comments on commit 04b295d

Please sign in to comment.