-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--allow=non-bmp #27
Comments
I assume this is related to the portability warning produced by jsonlint when reading JSON that contains a raw (not escaped) astral plane character in a string value, e.g., the first warning below:
whereas using the
First, for those that may read this issue... this should not be a problem if you are just reading JSON using the API, as when using the demjson module in your own Python application, nor when writing JSON. It is only a jsonlint issue where it tries to warn about valid, yet possibly non-portable data. Yes, this is a fair issue to raise. Back when demjson was written, and this warning in particular, there were many JSON implementations which could not handle the full Unicode repertoire, especially without using the escaped surrogate pair syntax. Hence the non-portability warning. I believe that these faulty implementations may be much rarer today, so separating this particular warning out with its own option probably makes sense. It probably warrants reviewing all the other non-portability warnings to see if any others are similar. I will look into this. |
Cf issue dmeranda#27. This is separating the case of non-BMP characters from the general non-portable property. It has the same default behaviour as non-portable.
Thanks for the answer. I've submitted a PR for this particular case, but if you have a better approach, feel free to ignore. :) |
Hi @dmeranda , I was wondering if I had any thoughts on this? |
Hi @dmeranda ; it's now been a few years; any chance this could get resolved, or should I look elsewhere? |
Hello!
Would it be possible to get a way to allow non-BMP characters? It is currently grouped together with non-portable issues, which is fair, but then I can't allow only non-BMP characters without allowing all the non-portable issues (like empty keys, for instance).
I'm happy to contribute it if you think there would be a chance it would be accepted.
The text was updated successfully, but these errors were encountered: