Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let gradle derive version name and version code from Git. Implements … #363

Merged
merged 1 commit into from
Jul 4, 2017
Merged

Let gradle derive version name and version code from Git. Implements … #363

merged 1 commit into from
Jul 4, 2017

Conversation

dmfs
Copy link
Owner

@dmfs dmfs commented Jul 4, 2017

…#362

@dmfs dmfs requested a review from lemonboston July 4, 2017 13:37
lemonboston
lemonboston approved these changes Jul 4, 2017
View reviewed changes
Copy link
Contributor

@lemonboston lemonboston left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, this are the versions in the built manifest currently:

    android:versionCode="542"
    android:versionName="1.1.8.2-74-g843e7ef"

@dmfs dmfs merged commit 903a6b7 into staging Jul 4, 2017
@dmfs dmfs deleted the mx/362-git-version branch July 4, 2017 13:47
@korelstar korelstar mentioned this pull request Mar 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemonboston lemonboston lemonboston approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmfs @lemonboston