-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracking objects for Microsoft Forms/-Stream/Slideshare/Youtube/Maps (#158) #167
Conversation
…-gmbh#154) [Crowdin pull request]
…-gmbh#161) [Crowdin pull request]
…-gmbh#165) [Crowdin pull request] Co-authored-by: Jonas Eberle <jonas.eberle@d-mind.de>
Thank you @okroener! Please disregard the failing CGL tests in master. We have an incompatibility between php-cs-fixer and the newest symfony/event-dispatcher with the current TYPO3 dev-master and we need to investigate. We would be happy to have the new TrackingObjects in https://github.com/dmind-gmbh/extension-cookieman/blob/master/Configuration/TypoScript/Example/setup.typoscript, too. So please feel free to re-add it :) Could you add your new strings to https://github.com/dmind-gmbh/extension-cookieman/blob/master/Resources/Private/Language/locallang.xlf, please? That will make them available for translators on https://crowdin.com/project/typo3-extension-cookieman. |
Hello @jonaseberle, thank you very much for your quick reply. Thanks for metioning the failing CGL tests, I have seen already that they work fine in other branches like 10lts. I am currently adding some more tracking objects and once I have finished that, I will take care of the translation and also update ../Example/setup.typoscript Then I will perform my pull request again. |
Hello @jonaseberle, I have now added futher tracking objects, changed the example and the translations as well. There is only one thing that I am not sure about at the moment. E.g. if there are two tracking objects with the same cookie name, e.g. Slideshare: UID and At the moment I can't see a way to have different translations for both different cookies since the translation files pick the cookie name, but not TackingObject.cookie_name? Another time thanks for the brilliant work! |
Hi @okroener thanks again! Regarding Duplicate tracking object names: It displays You can just call your trackingObject differently. So following your example, let's say
|
I am blown away @okroener! You also included Slideshare, Maps and Youtube! Splendid, thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the question if it's HTTP cookies should be answered. I am happy to merge then.
Hello @jonaseberle, thank you very much for your reply and the clarification of the translations. I should have looked into the template first, before asking that question :-) Regarding the cookies in MicrosoftForms/-Stream I have checked that again and have found out, that in Stream the cookies are all HttpOnly, but in Forms there are different types of cookies, like:
Keep up the great work! |
Thank you @okroener! |
You are welcome @jonaseberle and thanks for triggering the translation. At the moment I am adding more tracking objects in my local dev branch. I will make a pull request when I have completed that list in order to reduce the merging efforts. Thanks! |
Hello @jonaseberle ,
I have just added some support for Microsoft Forms cookies. Others will follow.
Thanks for your great work on this extension.