Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking objects for Microsoft Forms/-Stream/Slideshare/Youtube/Maps (#158) #167

Merged
merged 37 commits into from
Nov 18, 2020

Conversation

oliverkroener
Copy link
Contributor

Hello @jonaseberle ,

I have just added some support for Microsoft Forms cookies. Others will follow.

Thanks for your great work on this extension.

@jonaseberle
Copy link
Member

Thank you @okroener!

Please disregard the failing CGL tests in master. We have an incompatibility between php-cs-fixer and the newest symfony/event-dispatcher with the current TYPO3 dev-master and we need to investigate.

We would be happy to have the new TrackingObjects in https://github.com/dmind-gmbh/extension-cookieman/blob/master/Configuration/TypoScript/Example/setup.typoscript, too. So please feel free to re-add it :)

Could you add your new strings to https://github.com/dmind-gmbh/extension-cookieman/blob/master/Resources/Private/Language/locallang.xlf, please? That will make them available for translators on https://crowdin.com/project/typo3-extension-cookieman.

@oliverkroener
Copy link
Contributor Author

Hello @jonaseberle, thank you very much for your quick reply.

Thanks for metioning the failing CGL tests, I have seen already that they work fine in other branches like 10lts.

I am currently adding some more tracking objects and once I have finished that, I will take care of the translation and also update ../Example/setup.typoscript

Then I will perform my pull request again.

@oliverkroener
Copy link
Contributor Author

Hello @jonaseberle,

I have now added futher tracking objects, changed the example and the translations as well.

There is only one thing that I am not sure about at the moment. E.g. if there are two tracking objects with the same cookie name, e.g.

Slideshare: UID and
xyz: UID

At the moment I can't see a way to have different translations for both different cookies since the translation files pick the cookie name, but not TackingObject.cookie_name?

Another time thanks for the brilliant work!

@jonaseberle
Copy link
Member

Hi @okroener thanks again!

Regarding Duplicate tracking object names:

It displays trackingobject.cookie_name and falls back to cookie_name (https://github.com/dmind-gmbh/extension-cookieman/blob/master/Resources/Private/Partials/TableRowsByGroup.html#L8)

You can just call your trackingObject differently. So following your example, let's say UID is already defined and you want to add a second one with the same name:

# TypoScript
plugin.tx_cookieman.settings.trackingObjects {
    Slideshare {
        show {
            Slideshare_UID {
                duration = 1
                durationUnit = year
                type = cookie_http+html
                provider = Slideshare
# this makes sure the cookie "UID" will be deleted when unconsenting, although we called it Slideshare_UID internally.
                htmlCookieRemovalPattern = ^UID$
            }
        }
    }
}
# .xlf
<trans-unit id="trackingobject.slideshare_UID" resname="trackingobject.slideshare_UID">
  <source>UID</source>
</trans-unit>
<trans-unit id="trackingobject.slideshare_UID.desc" resname="trackingobject.slideshare_UID.desc">
  <source>Used for ...</source>
</trans-unit>

@jonaseberle jonaseberle changed the title Added cookies definitions for Microsoft Forms Added cookies definitions for Microsoft Forms/-Stream/Slideshare/Youtube/Maps Nov 12, 2020
@jonaseberle
Copy link
Member

I am blown away @okroener! You also included Slideshare, Maps and Youtube! Splendid, thank you!

Copy link
Member

@jonaseberle jonaseberle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the question if it's HTTP cookies should be answered. I am happy to merge then.

@jonaseberle jonaseberle changed the title Added cookies definitions for Microsoft Forms/-Stream/Slideshare/Youtube/Maps Add tracking objects for Microsoft Forms/-Stream/Slideshare/Youtube/Maps (#158) Nov 12, 2020
@oliverkroener
Copy link
Contributor Author

Hello @jonaseberle,

thank you very much for your reply and the clarification of the translations. I should have looked into the template first, before asking that question :-)

Regarding the cookies in MicrosoftForms/-Stream I have checked that again and have found out, that in Stream the cookies are all HttpOnly, but in Forms there are different types of cookies, like:

...
            __RequestVerificationToken {
                duration =
                durationUnit = session
                type = cookie_http
                provider = Microsoft
            }
            
            AADNonce\.forms {
                duration =
                durationUnit = session
                type = cookie_http
                provider = Microsoft
            }

            DcLcid {
                duration = 3
                durationUnit = months
                type = cookie_http
                provider = Microsoft
            }

            MSFPC {
                duration = 1
                durationUnit = year
                type = cookie_http+html
                provider = Microsoft
            }

            MUID {
                duration = 1
                durationUnit = year
                type = cookie_http+html
                provider = Microsoft
            }

Keep up the great work!

@jonaseberle jonaseberle merged commit c9763c4 into dmind-gmbh:master Nov 18, 2020
@jonaseberle
Copy link
Member

Thank you @okroener!

@oliverkroener
Copy link
Contributor Author

You are welcome @jonaseberle and thanks for triggering the translation.

At the moment I am adding more tracking objects in my local dev branch. I will make a pull request when I have completed that list in order to reduce the merging efforts.

Thanks!

jonaseberle pushed a commit that referenced this pull request Feb 14, 2021
…aps (#158) (#167)

Co-authored-by: Oliver Kroener <ok@oliver-kroener.de>
jonaseberle pushed a commit that referenced this pull request Feb 14, 2021
…aps (#158) (#167)

Co-authored-by: Oliver Kroener <ok@oliver-kroener.de>
jonaseberle pushed a commit that referenced this pull request Feb 14, 2021
…aps (#158) (#167)

Co-authored-by: Oliver Kroener <ok@oliver-kroener.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants