Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Css mask not working on Chrome (Webkit) #272

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Css mask not working on Chrome (Webkit) #272

merged 1 commit into from
Apr 6, 2022

Conversation

prathers
Copy link
Contributor

@prathers prathers commented Apr 6, 2022

The -webkit-mask-image is a solution according to this: https://stackoverflow.com/questions/44100139/css-mask-not-working-on-chrome-webkit

Testet in Brave Browser (Version 1.37.111 Chromium: 100.0.4896.79) and Chromium (v85.0.4154.0)

@prathers
Css mask not working on Chrome (Webkit)
debff6c 
The -webkit-mask-image is a solution according to this: https://stackoverflow.com/questions/44100139/css-mask-not-working-on-chrome-webkit

Testet in Brave Browser (Version 1.37.111 Chromium: 100.0.4896.79) and Chromium (v85.0.4154.0)
@prathers
Copy link
Contributor Author

prathers commented Apr 6, 2022

Haven't checked the other modals

@jonaseberle
Copy link
Member

Thanks!

Don't worry about the failing acceptance tests. We are hit by ddev/ddev#3734.

We should finally use scss + autoprefixer + browserslist for the theme CSS...

The other themes don't use mask-image so we are fine.

I'll backport to v10. just tell me if you need v9, too. And we can do a release tomorrow if you need one.

@jonaseberle
Copy link
Member

jonaseberle commented Apr 6, 2022 •
edited
Loading

Shouldn't it be working on Chrome/ium without prefix? https://caniuse.com/mdn-css_properties_mask-image_svg_masks
Nevermind, let's get this in.

@jonaseberle jonaseberle merged commit c2d58c4 into dmind-gmbh:master Apr 6, 2022
jonaseberle pushed a commit that referenced this pull request Apr 6, 2022
@prathers @jonaseberle
[BUGFIX] Support CSS SVG mask on on Chrome (bootstrap-5) (#272)
09c8152 
The -webkit-mask-image is a solution according to this: https://stackoverflow.com/questions/44100139/css-mask-not-working-on-chrome-webkit

Tested in Brave Browser (Version 1.37.111 Chromium: 100.0.4896.79) and Chromium (v85.0.4154.0)
@prathers
Copy link
Contributor Author

prathers commented Apr 7, 2022

Thanks @jonaseberle - I've tested mask-image in three different Webkit browsers and they all have the problem. As I understand, the solution is to add -webkit-* to all mask-* properties. But thanks for merging. And thanks for a great extension!

@prathers
Copy link
Contributor Author

prathers commented Apr 7, 2022

For my sake, no need for backporting. We're working on a v11.5 with BS v5

jonaseberle added a commit that referenced this pull request Apr 7, 2022
@jonaseberle
[RELEASE] 2.9.14
d23a9c9 
2022-04-06 [BUGFIX] Support CSS SVG mask on on Chrome (bootstrap-5) (#272) [Preben Rather Sørensen] (09c8152)
2022-04-06 [TASK] upgrade npm dependencies [Jonas Eberle] (e9957ad)
2022-02-15 [TASK] remove sec-advisories for C/I [Jonas Eberle] (7108ea4)
2022-02-15 [TASK] remove build:docs [Jonas Eberle] (950a847)
2022-02-15 [SECURITY] upgrade npm packages [Jonas Eberle] (4b090aa)
2022-02-15 [TASK] add composer allow-plugins:{} [Jonas Eberle] (edfff2c)
2022-02-15 [TASK] prepare selenium services for ddev 1.19 [Jonas Eberle] (7e4291e)
2021-12-15 [DOCS] fix external link [Jonas Eberle] (144f0d4)
2021-12-15 [DOCS] add translation link [Jonas Eberle] (e5f2f6a)
2021-12-15 [DOCS] restructure Documentation/Developers [Jonas Eberle] (ed1b242)
2021-12-15 [DOCS] fix typo [Jonas Eberle] (5cce5af)
2021-11-18 [FEATURE] Use <f:spaceless> to reduce output (#255) (#256) [Daniel Corn] (3ba80dc)
2021-10-18 [TASK] use tailor, drop CHANGELOG [Jonas Eberle] (513d6c7)
2021-10-18 [TASK] use tailor, drop CHANGELOG [Jonas Eberle] (0a613fc)
2021-10-18 [DOCS] reorder Configuration subpages [Jonas Eberle] (202799d)
2021-10-18 [DOCS] remove obsolete information [Jonas Eberle] (caabbef)
2021-10-18 [DOCS] add images, edit docu (#252) [Cem Yildiz] (08a8a8a)
2021-10-18 [DOCS] add Crowdin to README [Jonas Eberle] (7c30ba7)
jonaseberle added a commit that referenced this pull request Apr 7, 2022
@jonaseberle
[RELEASE] 2.9.15
a9bb308 
2022-04-06 [TASK] conflict with typo3/cms-composer-installers:v4 [Jonas Eberle] (873c3b9)
2022-04-06 [BUGFIX] Support CSS SVG mask on on Chrome (bootstrap-5) (#272) [Preben Rather Sørensen] (c2d58c4)
2022-04-06 [TASK] upgrade npm dependencies [Jonas Eberle] (47e315f)
2022-02-15 [SECURITY] upgrade npm packages [Jonas Eberle] (a981c67)
2022-02-15 [TASK] add composer allow-plugins:{} [Jonas Eberle] (9ddac66)
2022-02-15 [TASK] prepare selenium services for ddev 1.19 [Jonas Eberle] (0641df0)
2022-02-15 [TASK] remove build:docs [Jonas Eberle] (6d91a6f)
2022-01-14 Bump follow-redirects from 1.14.4 to 1.14.7 in /Build (#263) [dependabot[bot]] (a9f8562)
2021-12-15 [DOCS] fix external link [Jonas Eberle] (eb3ef58)
2021-12-15 [DOCS] add translation link [Jonas Eberle] (1f56b18)
2021-12-15 [DOCS] restructure Documentation/Developers [Jonas Eberle] (2baa1dd)
2021-12-15 [DOCS] fix typo [Jonas Eberle] (33c0a90)
2021-12-06 [TASK] switch to TYPO3 main branch, req testing-framework:^6 [Jonas Eberle] (37664f7)
2021-11-18 [FEATURE] Use <f:spaceless> to reduce output (#255) (#256) [Daniel Corn] (14d58df)
2021-11-18 [TASK] req phpunit:^9.5 [Jonas Eberle] (92c52e8)
2021-11-17 [BUGFIX] enable multiline release tag comments [Jonas Eberle] (f262d61)
jonaseberle added a commit that referenced this pull request Apr 7, 2022
@jonaseberle
[RELEASE] 2.9.17
0154a26 
2022-04-07 [RELEASE] 2.9.15 [Jonas Eberle] (a9bb308)
2022-04-06 [TASK] conflict with typo3/cms-composer-installers:v4 [Jonas Eberle] (873c3b9)
2022-04-06 [BUGFIX] Support CSS SVG mask on on Chrome (bootstrap-5) (#272) [Preben Rather Sørensen] (c2d58c4)
2022-04-06 [TASK] upgrade npm dependencies [Jonas Eberle] (47e315f)
2022-02-15 [SECURITY] upgrade npm packages [Jonas Eberle] (a981c67)
2022-02-15 [TASK] add composer allow-plugins:{} [Jonas Eberle] (9ddac66)
2022-02-15 [TASK] prepare selenium services for ddev 1.19 [Jonas Eberle] (0641df0)
2022-02-15 [TASK] remove build:docs [Jonas Eberle] (6d91a6f)
2022-01-14 Bump follow-redirects from 1.14.4 to 1.14.7 in /Build (#263) [dependabot[bot]] (a9f8562)
2021-12-15 [DOCS] fix external link [Jonas Eberle] (eb3ef58)
2021-12-15 [DOCS] add translation link [Jonas Eberle] (1f56b18)
2021-12-15 [DOCS] restructure Documentation/Developers [Jonas Eberle] (2baa1dd)
2021-12-15 [DOCS] fix typo [Jonas Eberle] (33c0a90)
2021-12-06 [TASK] switch to TYPO3 main branch, req testing-framework:^6 [Jonas Eberle] (37664f7)
2021-11-18 [FEATURE] Use <f:spaceless> to reduce output (#255) (#256) [Daniel Corn] (14d58df)
2021-11-18 [TASK] req phpunit:^9.5 [Jonas Eberle] (92c52e8)
2021-11-17 [BUGFIX] enable multiline release tag comments [Jonas Eberle] (f262d61)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prathers @jonaseberle